Skip to content

Fix GTFS sensor wrong timezone#26580

Merged
MartinHjelmare merged 1 commit into
home-assistant:devfrom
tsvi:gtfs_fix
Sep 11, 2019
Merged

Fix GTFS sensor wrong timezone#26580
MartinHjelmare merged 1 commit into
home-assistant:devfrom
tsvi:gtfs_fix

Conversation

@tsvi
Copy link
Copy Markdown
Contributor

@tsvi tsvi commented Sep 11, 2019

Breaking Change:

Description:

As part of the fixes of getting rid of a whole bunch of datetime.now(), instead of our timezone-aware dt_util.now(), this fixes the GTFS sensor.

Related issue (if applicable): fixes #24201

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@tsvi
Copy link
Copy Markdown
Contributor Author

tsvi commented Sep 11, 2019

@MartinHjelmare this one is a bugfix as well. Funny that the fix is already in the issue opened :)

@MartinHjelmare MartinHjelmare changed the title Fix for GTFS sensor wrong timezone Fix GTFS sensor wrong timezone Sep 11, 2019
@MartinHjelmare MartinHjelmare merged commit 7dfdec5 into home-assistant:dev Sep 11, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 12, 2019
@tsvi tsvi deleted the gtfs_fix branch September 19, 2019 11:26
@tsvi tsvi restored the gtfs_fix branch September 19, 2019 11:27
@tsvi tsvi deleted the gtfs_fix branch September 19, 2019 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GTFS loads wrong transport times due to not honoring local timezone

3 participants